Issue 258563004: Copy of Issue 231383002 after hard disk crash: First step in improving instance of test for a fixed…

Issue 258563004: Copy of Issue 231383002 after hard disk crash: First step in improving instance of test for a fixed… (Closed)

Created:
6 years, 8 months ago by srdjan

Modified:
6 years, 7 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Copy of Issue 231383002 after hard disk crash: First step in improving instance of test for a fixed set of value cids returning different results. Committed: https://code.google.com/p/dart/source/detail?r=35455

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 4

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+663 lines, -14 lines)			Patch
M	runtime/vm/code_generator.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4 5	8 chunks	+112 lines, -12 lines	4 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1 2 3 4 5	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2 3 4 5	1 chunk	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5	4 chunks	+74 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3 4 5	1 chunk	+29 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4 5	2 chunks	+73 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	1 2 3 4 5	1 chunk	+30 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	1 chunk	+72 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4 5	1 chunk	+72 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5	1 chunk	+72 lines, -0 lines	0 comments	Download
A	tests/language/instanceof_optimized_test.dart	View	1 2 3 4	1 chunk	+110 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #6 manually as r35455 (presubmit successful).

6 years, 8 months ago (2014-04-25 23:21:21 UTC) #3

Florian Schneider

lgtm https://codereview.chromium.org/258563004/diff/100001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/258563004/diff/100001/runtime/vm/flow_graph_optimizer.cc#newcode3686 runtime/vm/flow_graph_optimizer.cc:3686: results->Clear(); Is results reused somewhere? Maybe just ASSERT(result->is_empty()); ...

6 years, 7 months ago (2014-04-28 15:41:01 UTC) #4

srdjan

6 years, 7 months ago (2014-04-28 15:44:57 UTC) #5

Message was sent while issue was closed.

Addressing in  follow-up CL.

https://codereview.chromium.org/258563004/diff/100001/runtime/vm/flow_graph_o...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/258563004/diff/100001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:3686: results->Clear();
On 2014/04/28 15:41:01, Florian Schneider wrote:
> Is results reused somewhere? 
> Maybe just ASSERT(result->is_empty());

Done.

https://codereview.chromium.org/258563004/diff/100001/runtime/vm/flow_graph_o...
runtime/vm/flow_graph_optimizer.cc:3821: // const Class& type_class =
Class::Handle(type.type_class())
On 2014/04/28 15:41:01, Florian Schneider wrote:
> Remove commented-out code.

Done.

Expand Messages | Collapse Messages