Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 258523006: Reduce memory usage of test.dart: canonicalize Set<Expectation> (Closed)

Created:
6 years, 8 months ago by Bill Hesse
Modified:
6 years, 8 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Reduce memory usage of test.dart: canonicalize Set<Expectation> BUG=dartbug.com/18084 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=35375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/testing/dart/status_file_parser.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
This saves 4 MB on 2 configurations, 5 MB on 4 configurations.
6 years, 8 months ago (2014-04-24 14:53:46 UTC) #1
kustermann
LGTM
6 years, 8 months ago (2014-04-24 15:39:13 UTC) #2
Bill Hesse
6 years, 8 months ago (2014-04-24 15:42:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698