Check mixin of black-listed types.

Check mixin of black-listed types.

BUG=http://dartbug.com/12445
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28197

[Johnni Winther, 2013-10-03 07:39:53]

https://codereview.chromium.org/25844002/diff/1/tests/language/constant_type_...
File tests/language/constant_type_literal_test.dart (right):

https://codereview.chromium.org/25844002/diff/1/tests/language/constant_type_...
tests/language/constant_type_literal_test.dart:5: // Test for conditionals as
compile-time constants.
Forgot to add this test in the CL yesterday.

[karlklose, 2013-10-03 07:50:01]

LGTM.

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (left):

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3609:
supertype = applyMixin(supertype, resolveType(link.head), node);
How about: 'resolveType' -> 'checkMixinType'?

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3673:
supertype = applyMixin(supertype, resolveType(link.head), link.head);
Ditto.

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3724: 
Remove extra line.

https://codereview.chromium.org/25844002/diff/1/tests/language/mixin_black_li...
File tests/language/mixin_black_listed_test.dart (right):

https://codereview.chromium.org/25844002/diff/1/tests/language/mixin_black_li...
tests/language/mixin_black_listed_test.dart:7: import
'package:expect/expect.dart';
Tests for num are missing.

[Johnni Winther, 2013-10-03 08:00:25]

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (left):

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3609:
supertype = applyMixin(supertype, resolveType(link.head), node);
On 2013/10/03 07:50:01, karlklose wrote:
> How about: 'resolveType' -> 'checkMixinType'?

Done.

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3673:
supertype = applyMixin(supertype, resolveType(link.head), link.head);
On 2013/10/03 07:50:01, karlklose wrote:
> Ditto.

Done.

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/25844002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:3724: 
On 2013/10/03 07:50:01, karlklose wrote:
> Remove extra line.

Done.

https://codereview.chromium.org/25844002/diff/1/tests/language/mixin_black_li...
File tests/language/mixin_black_listed_test.dart (right):

https://codereview.chromium.org/25844002/diff/1/tests/language/mixin_black_li...
tests/language/mixin_black_listed_test.dart:7: import
'package:expect/expect.dart';
On 2013/10/03 07:50:01, karlklose wrote:
> Tests for num are missing.

It is in 05.

[Johnni Winther, 2013-10-03 08:10:58]

Committed patchset #3 manually as r28197 (presubmit successful).