Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 258133002: Ensures that stubs added to each object pool on x64 (Closed)

Created:
6 years, 7 months ago by zra
Modified:
6 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Ensures that stubs added to each object pool on x64 are generated before they are used by reordering the list of stubs. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35524

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M runtime/vm/assembler_arm64.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/stub_code.h View 2 chunks +1 line, -1 line 0 comments Download
A tests/standalone/io/directory_list_sync_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zra
6 years, 7 months ago (2014-04-28 18:51:29 UTC) #1
Ivan Posva
LGTM -ip https://codereview.chromium.org/258133002/diff/20001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/258133002/diff/20001/runtime/vm/assembler_arm64.cc#newcode52 runtime/vm/assembler_arm64.cc:52: const Smi& vacant = Smi::Handle(Smi::New(0xfa)); >> SmiTagShift ...
6 years, 7 months ago (2014-04-29 05:31:04 UTC) #2
zra
https://codereview.chromium.org/258133002/diff/20001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/258133002/diff/20001/runtime/vm/assembler_arm64.cc#newcode52 runtime/vm/assembler_arm64.cc:52: const Smi& vacant = Smi::Handle(Smi::New(0xfa)); On 2014/04/29 05:31:04, Ivan ...
6 years, 7 months ago (2014-04-29 14:47:48 UTC) #3
zra
6 years, 7 months ago (2014-04-29 14:48:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r35524 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698