Issue 25813002: - Rename arrays to lists:

Issue 25813002: - Rename arrays to lists: (Closed)

Created:
7 years, 2 months ago by Ivan Posva

Modified:
7 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Rename arrays to lists: _ObjectArray -> _List _GrowableObjectArray -> _GrowableList _ImmutableArray -> _ImmutableList R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28189

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -169 lines)			Patch
M	runtime/lib/array.cc	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/lib/array.dart	View	1	5 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/lib/array_patch.dart	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/lib/growable_array.cc	View		5 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/lib/growable_array.dart	View	1	4 chunks	+20 lines, -20 lines	0 comments	Download
M	runtime/lib/immutable_map.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/string_patch.dart	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	2 chunks	+12 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	4 chunks	+15 lines, -15 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1	1 chunk	+14 lines, -14 lines	0 comments	Download
M	runtime/vm/intrinsifier.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View	1	10 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1	12 chunks	+12 lines, -12 lines	0 comments	Download
M	runtime/vm/intrinsifier_mips.cc	View	1	11 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1	10 chunks	+11 lines, -11 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	7 chunks	+10 lines, -10 lines	1 comment	Download
M	runtime/vm/symbols.h	View	1	1 chunk	+6 lines, -6 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

First set of changes for _GrowableList. More to follow... -Ivan

7 years, 2 months ago (2013-10-02 22:49:28 UTC) #1

srdjan

lgtm https://codereview.chromium.org/25813002/diff/9001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/25813002/diff/9001/runtime/vm/object.cc#newcode157 runtime/vm/object.cc:157: V(CoreLibrary, _List, _List.) \ Formatting https://codereview.chromium.org/25813002/diff/9001/runtime/vm/symbols.h File runtime/vm/symbols.h ...

7 years, 2 months ago (2013-10-03 00:13:30 UTC) #4

Ivan Posva

7 years, 2 months ago (2013-10-03 00:15:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r28189 (presubmit successful).

Expand Messages | Collapse Messages