Issue 257793005: Fix SIMARM64 to compile on Mac, fix compilation because of ICData change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257793005: Fix SIMARM64 to compile on Mac, fix compilation because of ICData change. (Closed)

Created:
6 years, 8 months ago by srdjan

Modified:
6 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix SIMARM64 to compile on Mac, fix compilation because of ICData change. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35460

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	runtime/vm/code_descriptors.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

regis

LGTM Sorry for the bad global find and replace. gcc on linux does not seem ...

6 years, 8 months ago (2014-04-26 00:12:16 UTC) #2

srdjan

6 years, 8 months ago (2014-04-26 00:13:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35460 (presubmit successful).