verify() for mocks

verify() for mocks

R=paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=35428

[Paul Berry, 2014-04-25 16:06:11]

lgtm

https://codereview.chromium.org/257783005/diff/1/pkg/analysis_server/test/typ...
File pkg/analysis_server/test/typed_mock_test.dart (right):

https://codereview.chromium.org/257783005/diff/1/pkg/analysis_server/test/typ...
pkg/analysis_server/test/typed_mock_test.dart:235: obj.testMethodVoid(10);
How is this a void method?  Did you mean to do this instead?

obj.testMethodVoid();
obj.testMethodVoid();
verify(obj.testMethodVoid()).times(2);

[scheglov, 2014-04-25 16:12:32]

https://codereview.chromium.org/257783005/diff/1/pkg/analysis_server/test/typ...
File pkg/analysis_server/test/typed_mock_test.dart (right):

https://codereview.chromium.org/257783005/diff/1/pkg/analysis_server/test/typ...
pkg/analysis_server/test/typed_mock_test.dart:235: obj.testMethodVoid(10);
On 2014/04/25 16:06:11, Paul Berry wrote:
> How is this a void method?  Did you mean to do this instead?
> 
> obj.testMethodVoid();
> obj.testMethodVoid();
> verify(obj.testMethodVoid()).times(2);

We call a method that _returns_ "void".

In Mockito such methods require a special handling.
I was pleasantly surprised last night that in Dart we don't need it because
verify(dynamic) easily accepts void argument.

[scheglov, 2014-04-25 16:14:22]

Committed patchset #1 manually as r35428 (presubmit successful).