New analyzer snapshot, based on r35422.

New analyzer snapshot, based on r35422.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35426

[Paul Berry, 2014-04-25 14:01:58]

https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/pubspec.yam...
pkg/analyzer/pubspec.yaml:2: version: 0.14.2
I'm unsure whether this should be bumped to 0.14.2 or 0.15.0.  Any advice?

[scheglov, 2014-04-25 14:22:10]

LGTM with comments.

1. We need something to do with unit members sorting. It seems that on our
computers different order of them is produced.

2. I'm surprised that there was no resolver_test.dart changes.

https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/pubspec.yaml
File pkg/analyzer/pubspec.yaml (right):

https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/pubspec.yam...
pkg/analyzer/pubspec.yaml:2: version: 0.14.2
On 2014/04/25 14:01:58, Paul Berry wrote:
> I'm unsure whether this should be bumped to 0.14.2 or 0.15.0.  Any advice?

General rule - if there is an incompatible API change, increment major version.
If fixes and improvements - increment second most important version digit.
While we are under 1.0, our first digit is always 0.

https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/test/genera...
File pkg/analyzer/test/generated/all_test.dart (right):

https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/test/genera...
pkg/analyzer/test/generated/all_test.dart:1: library engine.test;
Remove this file.
It is for our convenience to run tests locally.
But bot will all all of the _test files anyway.

[Paul Berry, 2014-04-25 15:09:05]

On 2014/04/25 14:22:10, scheglov wrote:
> LGTM with comments.
> 
> 1. We need something to do with unit members sorting. It seems that on our
> computers different order of them is produced.

That's surprising.  Let's discuss that in the office today.

> 
> 2. I'm surprised that there was no resolver_test.dart changes.

Oops, I should have mentioned that "git cl upload" decided not to upload that
file because it was too big :(
If you want to review it, let me know and I guess I can find some other way to
share it with you.

> 
> https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/pubspec.yaml
> File pkg/analyzer/pubspec.yaml (right):
> 
>
https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/pubspec.yam...
> pkg/analyzer/pubspec.yaml:2: version: 0.14.2
> On 2014/04/25 14:01:58, Paul Berry wrote:
> > I'm unsure whether this should be bumped to 0.14.2 or 0.15.0.  Any advice?
> 
> General rule - if there is an incompatible API change, increment major
version.
> If fixes and improvements - increment second most important version digit.
> While we are under 1.0, our first digit is always 0.

Ok, that was my assumption.  Am I correct that there haven't been any
incompatible API changes since the last analyzer snapshot?

> 
>
https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/test/genera...
> File pkg/analyzer/test/generated/all_test.dart (right):
> 
>
https://codereview.chromium.org/257773008/diff/10001/pkg/analyzer/test/genera...
> pkg/analyzer/test/generated/all_test.dart:1: library engine.test;
> Remove this file.
> It is for our convenience to run tests locally.
> But bot will all all of the _test files anyway.

Done.

[Paul Berry, 2014-04-25 15:18:34]

Committed patchset #2 manually as r35426 (presubmit successful).

[Brian Wilkerson, 2014-04-25 15:20:07]

LGTM