Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 257433002: - Update status file to mark crashing test while investigating. (Closed)

Created:
6 years, 8 months ago by Ivan Posva
Modified:
6 years, 8 months ago
Reviewers:
Anders Johnsen, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen
Visibility:
Public.

Description

- Update status file to mark crashing test while investigating. - Remove unused fields from socket code. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=35346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M runtime/bin/socket.h View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/socket.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ivan Posva
6 years, 8 months ago (2014-04-24 00:35:50 UTC) #1
siva
lgtm
6 years, 8 months ago (2014-04-24 00:37:24 UTC) #2
Ivan Posva
Committed patchset #1 manually as r35346 (presubmit successful).
6 years, 8 months ago (2014-04-24 00:37:59 UTC) #3
Anders Johnsen
6 years, 8 months ago (2014-04-24 06:49:48 UTC) #4
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698