port polymer data binding tests

port polymer data binding tests

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29139

[Jennifer Messerly, 2013-10-03 04:33:28]

these are from:
https://github.com/Polymer/polymer/tree/4dc481c11505991a7c43228d3797d28f21267...

[Siggi Cherem (dart-lang), 2013-10-04 21:13:46]

lgtm

https://codereview.chromium.org/25740006/diff/7001/pkg/polymer/test/bind_test...
File pkg/polymer/test/bind_test.dart (right):

https://codereview.chromium.org/25740006/diff/7001/pkg/polymer/test/bind_test...
pkg/polymer/test/bind_test.dart:12: test('ready called', () =>
query('x-foo').xtag.onTestDone);
could we also check that this is not null before returning it (I worry about
this callback returning null and completing before anything is run)

https://codereview.chromium.org/25740006/diff/7001/pkg/polymer/test/unbind_te...
File pkg/polymer/test/unbind_test.dart (right):

https://codereview.chromium.org/25740006/diff/7001/pkg/polymer/test/unbind_te...
pkg/polymer/test/unbind_test.dart:72: },
totally optional, but since every callback takes a single argument, it might be
fine to do each delay here and forward results:

  return delay(null)
      .then((_) { expect ... xTest.remove(); })
      .then(delay)
      .then((_) { ... return createElement('x-test').xtag; })
      .then(delay)
      .then((node) { ... return node; })
      ...


where delay is:

Future delay(arg) =>
  new Future.deplayed(new Duration(milliseconds: ms).then((_) => arg);


But I'm totally fine keeping it how it is if you think it's not worth it.

[Jennifer Messerly, 2013-10-24 00:33:59]

PTAL -- updated this to latest

[Siggi Cherem (dart-lang), 2013-10-24 00:50:42]

lgtm, minor comments below

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_mdv...
File pkg/polymer/test/bind_mdv_test.dart (right):

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_mdv...
pkg/polymer/test/bind_mdv_test.dart:69: Observable.dirtyCheck();
is this needed if you are using endOfMicrotask below?

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_tes...
File pkg/polymer/test/bind_test.dart (right):

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_tes...
pkg/polymer/test/bind_test.dart:27: //
remove?

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_tes...
pkg/polymer/test/bind_test.dart:43: test('ready called', () =>
query('x-foo').xtag.onTestDone);
remove xtag

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/template...
File pkg/polymer/test/template_distribute_dynamic_test.dart (right):

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/template...
pkg/polymer/test/template_distribute_dynamic_test.dart:64: test('inserted
called', () => query('x-test').xtag.onTestDone);
remove .xtag

[Jennifer Messerly, 2013-10-24 00:58:58]

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_mdv...
File pkg/polymer/test/bind_mdv_test.dart (right):

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_mdv...
pkg/polymer/test/bind_mdv_test.dart:69: Observable.dirtyCheck();
On 2013/10/24 00:50:43, Siggi Cherem (dart-lang) wrote:
> is this needed if you are using endOfMicrotask below?

yeah ... the end of microtask runs faster than polymer can update the property

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_tes...
File pkg/polymer/test/bind_test.dart (right):

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_tes...
pkg/polymer/test/bind_test.dart:27: //
On 2013/10/24 00:50:43, Siggi Cherem (dart-lang) wrote:
> remove?

sure. I think that was from original :)

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/bind_tes...
pkg/polymer/test/bind_test.dart:43: test('ready called', () =>
query('x-foo').xtag.onTestDone);
On 2013/10/24 00:50:43, Siggi Cherem (dart-lang) wrote:
> remove xtag

Done.

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/template...
File pkg/polymer/test/template_distribute_dynamic_test.dart (right):

https://codereview.chromium.org/25740006/diff/12001/pkg/polymer/test/template...
pkg/polymer/test/template_distribute_dynamic_test.dart:64: test('inserted
called', () => query('x-test').xtag.onTestDone);
On 2013/10/24 00:50:43, Siggi Cherem (dart-lang) wrote:
> remove .xtag

Done.

[Jennifer Messerly, 2013-10-24 00:59:42]

Committed patchset #5 manually as r29139 (presubmit successful).