Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 25731003: Use Directory.systemTemp getter in pkg subdirectory of repository. (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use Directory.systemTemp getter in pkg subdirectory of repository. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28218

Patch Set 1 #

Patch Set 2 : Change createSystemTemp to systemTemp.createTemp. #

Patch Set 3 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -73 lines) Patch
M pkg/analyzer_experimental/test/utils.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M pkg/barback/test/asset_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/test/single_library_test.dart View 1 2 4 chunks +35 lines, -34 lines 0 comments Download
M pkg/http/test/multipart_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/http_server/test/virtual_directory_test.dart View 1 2 29 chunks +35 lines, -29 lines 0 comments Download
M pkg/scheduled_test/lib/descriptor.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/scheduled_test/test/descriptor/utils.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/scheduled_process_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/watcher/test/utils.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 2 months ago (2013-10-02 16:20:37 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/25731003/diff/5001/pkg/http_server/test/virtual_directory_test.dart File pkg/http_server/test/virtual_directory_test.dart (right): https://codereview.chromium.org/25731003/diff/5001/pkg/http_server/test/virtual_directory_test.dart#newcode178 pkg/http_server/test/virtual_directory_test.dart:178: var dir = Directory.systemTemp.createTempSync('http_server_virtual_'); Long line - more ...
7 years, 2 months ago (2013-10-02 17:00:48 UTC) #2
Bill Hesse
7 years, 2 months ago (2013-10-03 13:12:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r28218 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698