Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 257243002: Don't use AI_V4MAPPED. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
zra, Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don't use AI_V4MAPPED. AI_V4MAPPED only effects when we are restricted to IPv6. That can only happen if the user requests _only_ IPv6. Thus, don't map IPv4 addrs into IPv6. BUG= R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=35538

Patch Set 1 #

Patch Set 2 : Also for win. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/bin/socket_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-04-29 18:44:56 UTC) #1
zra
lgtm
6 years, 7 months ago (2014-04-29 18:55:47 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-04-29 19:40:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698