Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25720002: Add Directory.systemTemp getter to replace createSystemTemp(). (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add Directory.systemTemp getter to replace createSystemTemp(). BUG=dartbug.com/12496 R=rnystrom@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28215

Patch Set 1 #

Patch Set 2 : Add dart2js patch files. #

Total comments: 4

Patch Set 3 : Leave prefix argument optional. #

Patch Set 4 : Add mac and android platforms to change. #

Patch Set 5 : Replace code with the equivalent strdup. #

Patch Set 6 : Don't add an extra / to a directory ending in // #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -200 lines) Patch
M pkg/docgen/test/single_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/builtin_natives.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/directory.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/directory.cc View 1 2 3 2 chunks +11 lines, -21 lines 0 comments Download
M runtime/bin/directory_android.cc View 1 2 3 4 2 chunks +22 lines, -26 lines 0 comments Download
M runtime/bin/directory_linux.cc View 1 2 3 4 2 chunks +17 lines, -23 lines 0 comments Download
M runtime/bin/directory_macos.cc View 1 2 3 4 2 chunks +17 lines, -23 lines 0 comments Download
M runtime/bin/directory_patch.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/directory_win.cc View 1 2 3 1 chunk +14 lines, -12 lines 0 comments Download
M runtime/bin/io_service.h View 1 chunk +5 lines, -6 lines 0 comments Download
M sdk/lib/_internal/lib/io_patch.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +7 lines, -6 lines 0 comments Download
M sdk/lib/io/directory.dart View 1 2 1 chunk +21 lines, -35 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 1 2 3 4 5 3 chunks +24 lines, -36 lines 0 comments Download
M sdk/lib/io/io_service.dart View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bill Hesse
7 years, 2 months ago (2013-10-02 13:51:46 UTC) #1
Søren Gjesse
LGTM https://codereview.chromium.org/25720002/diff/3001/sdk/lib/io/directory.dart File sdk/lib/io/directory.dart (right): https://codereview.chromium.org/25720002/diff/3001/sdk/lib/io/directory.dart#newcode82 sdk/lib/io/directory.dart:82: * characters are appended to [template] to produce ...
7 years, 2 months ago (2013-10-02 16:57:37 UTC) #2
Bob Nystrom
Pub changes LGTM.
7 years, 2 months ago (2013-10-02 19:21:10 UTC) #3
Bill Hesse
https://codereview.chromium.org/25720002/diff/3001/sdk/lib/io/directory.dart File sdk/lib/io/directory.dart (right): https://codereview.chromium.org/25720002/diff/3001/sdk/lib/io/directory.dart#newcode82 sdk/lib/io/directory.dart:82: * characters are appended to [template] to produce a ...
7 years, 2 months ago (2013-10-03 12:15:19 UTC) #4
Søren Gjesse
lgtm We should consider always remove any trailing slashes from the systemTemp.
7 years, 2 months ago (2013-10-03 12:25:21 UTC) #5
Bill Hesse
7 years, 2 months ago (2013-10-03 12:55:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 manually as r28215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698