Issue 25719003: Fixing Node.clone not returning upgraded custom elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25719003: Fixing Node.clone not returning upgraded custom elements. (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing Node.clone not returning upgraded custom elements. This was an issue for Polymer as the templates are cloned with shallow clones. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28363

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	tests/html/custom/constructor_calls_created_synchronously_test.dart	View		1 chunk	+19 lines, -2 lines	0 comments	Download
	M	tools/dom/idl/dart/dart.idl	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

vsm

Is there a corresponding Dartium CL with the custom implementation?

7 years, 2 months ago (2013-10-07 17:48:13 UTC) #2

blois

7 years, 2 months ago (2013-10-08 16:02:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r28363 (presubmit successful).