Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 25719002: Use selectors instead of names to know if a call site returns the element of a list. This fixes the… (Closed)

Created:
7 years, 2 months ago by ngeoffray
Modified:
7 years, 2 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use selectors instead of names to know if a call site returns the element of a list. This fixes the bug where, for example, a.last() would return the element type of the list. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart View 1 chunk +11 lines, -11 lines 0 comments Download
A tests/language/list_tracer_call_last_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 2 months ago (2013-10-02 13:06:44 UTC) #1
kasperl
LGTM.
7 years, 2 months ago (2013-10-02 13:08:11 UTC) #2
ngeoffray
7 years, 2 months ago (2013-10-02 14:07:34 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28163 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698