Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 25713002: - Eliminated the excessive prefixing in the renamer of dart2dart. (Closed)

Created:
7 years, 2 months ago by bakster
Modified:
7 years, 2 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Eliminated the excessive prefixing in the renamer of dart2dart. - Increased a table size from 128 to 1024. Used in the parser for token compression. Startup is now twice as fast for app that has been through dart2dart. (this is a temporary fix for issue 13747) R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28158

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 1 chunk +39 lines, -39 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bakster
7 years, 2 months ago (2013-10-02 11:57:39 UTC) #1
bakster
7 years, 2 months ago (2013-10-02 11:58:10 UTC) #2
bakster
7 years, 2 months ago (2013-10-02 11:58:51 UTC) #3
kasperl
LGTM. https://codereview.chromium.org/25713002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart (right): https://codereview.chromium.org/25713002/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart#newcode320 sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:320: StringBuffer resultBuilder = new StringBuffer(); Probably not a ...
7 years, 2 months ago (2013-10-02 12:10:01 UTC) #4
bakster
7 years, 2 months ago (2013-10-02 13:03:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r28158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698