Issue 257053003: Always use the same json for null in the vm service.

Issue 257053003: Always use the same json for null in the vm service. (Closed)

Created:
6 years, 7 months ago by turnidge

Modified:
6 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Always use the same json for null in the vm service. PrintToJSONStream -> PrintJSON. ALSO: Fix <em> tags in the Observatory. BUG= R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35532

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : gen js #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -188 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View	1 2	4 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View	1 2	4 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/css/shared.css	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/css/shared.css	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/class_table.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/class_table.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/coverage.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/coverage.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/debugger.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/isolate.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/json_stream.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/json_test.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1 2	4 chunks	+10 lines, -6 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	62 chunks	+114 lines, -116 lines	0 comments	Download
M	runtime/vm/object_test.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/profiler.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/profiler.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/service.cc	View		25 chunks	+26 lines, -38 lines	0 comments	Download
M	runtime/vm/service_test.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm after comments https://codereview.chromium.org/257053003/diff/20001/runtime/vm/object.h File runtime/vm/object.h (right): https://codereview.chromium.org/257053003/diff/20001/runtime/vm/object.h#newcode141 runtime/vm/object.h:141: protected: /* NOLINT */ \ whitespace ...

6 years, 7 months ago (2014-04-28 21:27:20 UTC) #2

turnidge

6 years, 7 months ago (2014-04-29 18:10:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r35532 (presubmit successful).

Expand Messages | Collapse Messages