Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25700002: Removed flaky markers for consistently passing tests, marked 01_Constants_A15_t16 as failing (Closed)

Created:
7 years, 2 months ago by kustermann
Modified:
7 years, 2 months ago
Reviewers:
kasperl, Ivan Posva
CC:
reviews_dartlang.org, ricow1, Ivan Posva, hausner
Visibility:
Public.

Description

Removed flaky markers for consistently passing tests, marked 01_Constants_A15_t16 as failing TBR=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tests/co19/co19-runtime.status View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kustermann
The failing test is making all VM builders red.
7 years, 2 months ago (2013-10-02 09:39:43 UTC) #1
kustermann
@ivan: These were the two flaky markers.
7 years, 2 months ago (2013-10-02 09:40:17 UTC) #2
kustermann
Committed patchset #1 manually as r28143 (presubmit successful).
7 years, 2 months ago (2013-10-02 09:40:37 UTC) #3
kustermann
@hausner: Please don't commit and leave. Your change left all the VM builders red.
7 years, 2 months ago (2013-10-02 09:53:38 UTC) #4
kasperl
LGTM. Thanks, Martin!
7 years, 2 months ago (2013-10-02 10:11:04 UTC) #5
Ivan Posva
7 years, 2 months ago (2013-10-03 00:24:25 UTC) #6
Message was sent while issue was closed. 
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698