Issue 25687003: IssueRead for DirectoryWatcherHandle as soon as the watcher starts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25687003: IssueRead for DirectoryWatcherHandle as soon as the watcher starts. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

IssueRead for DirectoryWatcherHandle as soon as the watcher starts. This makes sure we don't miss any initial events. BUG=https://code.google.com/p/dart/issues/detail?id=13228

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -18 lines)			Patch
	M	runtime/bin/file_system_watcher_win.cc	View		1 chunk	+5 lines, -2 lines	2 comments	Download
	M	tests/standalone/io/file_system_watcher_test.dart	View		8 chunks	+12 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/25687003/diff/1/runtime/bin/file_system_watcher_win.cc File runtime/bin/file_system_watcher_win.cc (right): https://codereview.chromium.org/25687003/diff/1/runtime/bin/file_system_watcher_win.cc#newcode54 runtime/bin/file_system_watcher_win.cc:54: handle->EnsureInitialized(EventHandler::delegate()); Please add a comment here on why ...

7 years, 2 months ago (2013-10-02 10:53:34 UTC) #2

Anders Johnsen

7 years, 2 months ago (2013-10-02 11:09:55 UTC) #3

https://codereview.chromium.org/25687003/diff/1/runtime/bin/file_system_watch...
File runtime/bin/file_system_watcher_win.cc (right):

https://codereview.chromium.org/25687003/diff/1/runtime/bin/file_system_watch...
runtime/bin/file_system_watcher_win.cc:54:
handle->EnsureInitialized(EventHandler::delegate());
On 2013/10/02 10:53:34, Søren Gjesse wrote:
> Please add a comment here on why this is done.

Done.

Expand Messages | Collapse Messages