Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 25674009: Add framework for Dart_Terminate which will cleanup stuff on exit. (Closed)

Created:
7 years, 2 months ago by siva
Modified:
7 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix for 12312 (Dartium crash when reloading after running tests). Add framework for Dart_Cleanup which will cleanup stuff on exit. Ideally the VM isolate should be shutdown in Dart_Terminate but we don't seem to have a clean thread pool shutdown as a result of which there are racing isolates. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28248

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -6 lines) Patch
M runtime/bin/main.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/code_observers.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/dart.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart.cc View 2 chunks +31 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 2 months ago (2013-10-02 23:11:01 UTC) #1
Ivan Posva
LGTM Maybe the less involved solution would have been to not unregister the code observers. ...
7 years, 2 months ago (2013-10-03 21:53:28 UTC) #2
siva
On 2013/10/03 21:53:28, Ivan Posva wrote: > LGTM > > Maybe the less involved solution ...
7 years, 2 months ago (2013-10-03 21:57:44 UTC) #3
siva
7 years, 2 months ago (2013-10-03 22:17:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28248 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698