Fix issue 13474. Simplify graph builder for Boolean operators AND, OR: do not optimize code when th…

Fix issue 13474. Simplify graph builder for Boolean operators AND, OR: do not optimize code when the result of the Boolean operator is not used.

R=kmillikin@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28275

[Florian Schneider, 2013-10-02 10:09:21]

dbc: When in an effect context, the result of the right-hand side of && and ||
is only needed in checked mode. In unchecked mode, the existing code works fine
and is more compact.

[srdjan, 2013-10-02 13:42:12]

On 2013/10/02 10:09:21, Florian Schneider wrote:
> dbc: When in an effect context, the result of the right-hand side of && and ||
> is only needed in checked mode. In unchecked mode, the existing code works
fine
> and is more compact.

That kind of code is very rare, i.e, the benefit of that kind of (premature?)
optimization is miniscule. However, it requires more code in the VM and has
therefore potential for more bugs ... Q.E.D :-).

Kevin?

[srdjan, 2013-10-02 21:04:23]

Addressed objections. PTAL

[srdjan, 2013-10-03 16:10:38]

Ping?

[Kevin Millikin (Google), 2013-10-04 10:38:22]

LGTM.

[srdjan, 2013-10-04 19:43:24]

Committed patchset #9 manually as r28275 (presubmit successful).