Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25626002: Generate a library ID instead of a library name, so that the ID can be used (Closed)

Created:
7 years, 2 months ago by siva
Modified:
7 years, 2 months ago
Reviewers:
vsm, rmacnak
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Generate a library ID instead of a library name, so that the ID can be used to get the library handles from the cache (avoids having to lookup everytime) R=rmacnak@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28226

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -5 lines) Patch
M tools/dom/scripts/dartdomgenerator.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 3 4 2 chunks +37 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dartium/cpp_header.template View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/cpp_implementation.template View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
siva
7 years, 2 months ago (2013-10-02 00:31:41 UTC) #1
siva
synched to TOT.
7 years, 2 months ago (2013-10-02 20:50:46 UTC) #2
rmacnak
https://codereview.chromium.org/25626002/diff/8001/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/25626002/diff/8001/tools/dom/scripts/htmlrenamer.py#newcode758 tools/dom/scripts/htmlrenamer.py:758: _library_ids = monitored.Dict('htmlrenamer._library_names', { htmlrenamer._library_ids
7 years, 2 months ago (2013-10-02 21:22:48 UTC) #3
siva
https://codereview.chromium.org/25626002/diff/8001/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/25626002/diff/8001/tools/dom/scripts/htmlrenamer.py#newcode758 tools/dom/scripts/htmlrenamer.py:758: _library_ids = monitored.Dict('htmlrenamer._library_names', { On 2013/10/02 21:22:48, Ryan Macnak ...
7 years, 2 months ago (2013-10-02 23:28:27 UTC) #4
rmacnak
lgtm
7 years, 2 months ago (2013-10-03 00:56:57 UTC) #5
vsm
lgtm
7 years, 2 months ago (2013-10-03 16:15:00 UTC) #6
siva
7 years, 2 months ago (2013-10-03 16:21:22 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 manually as r28226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698