Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 256243002: Don’t set more than one code breakpoint per token position (Closed)

Created:
6 years, 7 months ago by hausner
Modified:
6 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Don’t set more than one code breakpoint per token position Some time ago when operator== calls had inlined null checks at the call site, the debugger had to instrument multiple code breakpoints that were all mapping to the same source position. This is no longer necessary. This change makes sure we set a code breakpoint only at the lowest compiled code address, so that expressions like i++ no longer result in 2 or 3 breakpoints (one each for load filed, add, store field). Fixes 18397. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35510

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M runtime/vm/debugger.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 3 chunks +25 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
6 years, 7 months ago (2014-04-28 23:37:07 UTC) #1
srdjan
lgtm
6 years, 7 months ago (2014-04-28 23:40:15 UTC) #2
hausner
6 years, 7 months ago (2014-04-28 23:40:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698