Issue 256233005: Update documentation of StreamSubscription.cancel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256233005: Update documentation of StreamSubscription.cancel. (Closed)

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 7 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update documentation of StreamSubscription.cancel. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=35519

Patch Set 2 : Address comments. #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	sdk/lib/async/stream.dart	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

https://codereview.chromium.org/256233005/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/256233005/diff/1/sdk/lib/async/stream.dart#newcode1177 sdk/lib/async/stream.dart:1177: * May return `null` if there is no need ...

6 years, 7 months ago (2014-04-29 09:17:53 UTC) #1

Anders Johnsen

lgtm https://codereview.chromium.org/256233005/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/256233005/diff/1/sdk/lib/async/stream.dart#newcode1175 sdk/lib/async/stream.dart:1175: * In that case, the file should not ...

6 years, 7 months ago (2014-04-29 09:46:01 UTC) #2

Lasse Reichstein Nielsen

6 years, 7 months ago (2014-04-29 10:35:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35519 (presubmit successful).

Expand Messages | Collapse Messages

Issue 256233005: Update documentation of StreamSubscription.cancel. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages