Issue 256003002: JavaScript Binary expressions not subclass of Call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 256003002: JavaScript Binary expressions not subclass of Call (Closed)

Created:
6 years, 8 months ago by sra1

Modified:
6 years, 7 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

JavaScript Binary expressions not subclass of Call About a 15% decrease in VariableUse nodes and a similar number of small lists (two Lists for each Binary/Prefix/Postfix - a short growable List and it's backing fixed size List). R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=35494

Patch Set 1 : #

Patch Set 2 : merge #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -49 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js/nodes.dart	View	1	4 chunks	+38 lines, -45 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js/template.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. (fyi: the JS-AST was ported from a JS-to-Scheme compiler where I treated binary ops ...

6 years, 7 months ago (2014-04-28 12:16:40 UTC) #2

sra1

6 years, 7 months ago (2014-04-28 19:57:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35494 (presubmit successful).

Expand Messages | Collapse Messages