Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 25570002: Support defining console variables with var consoleVar = someValue syntax (Closed)

Created:
7 years, 2 months ago by Jacob
Modified:
7 years, 2 months ago
Reviewers:
vsm, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support defining console variables with var consoleVar = someValue syntax rename $var to $consoleVariables move detection of JS console logic to .dart code from .js code See https://codereview.chromium.org/24989007/ for the matching Blink change. BUG= R=blois@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28243

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -6 lines) Patch
M tools/dom/src/native_DOMImplementation.dart View 1 3 chunks +121 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jacob
This CL goes along with https://codereview.chromium.org/24989007 to land true Dartium REPL support. We had to ...
7 years, 2 months ago (2013-10-01 18:12:39 UTC) #1
blois
lgtm
7 years, 2 months ago (2013-10-02 18:09:41 UTC) #2
vsm
lgtm https://chromiumcodereview.appspot.com/25570002/diff/4001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://chromiumcodereview.appspot.com/25570002/diff/4001/tools/dom/src/native_DOMImplementation.dart#newcode247 tools/dom/src/native_DOMImplementation.dart:247: // TODO(jacobr): remove the parentheses around the expresson ...
7 years, 2 months ago (2013-10-03 16:04:06 UTC) #3
Jacob
7 years, 2 months ago (2013-10-03 20:40:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r28243 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698