Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 25566002: Factor out throwing of argument error. (Closed)

Created:
7 years, 2 months ago by srdjan
Modified:
7 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, sra1
Visibility:
Public.

Description

Factor out throwing of argument error. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28109

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -74 lines) Patch
runtime/lib/array.cc View 1 chunk +2 lines, -6 lines 0 comments Download
runtime/lib/date.cc View 2 chunks +2 lines, -6 lines 0 comments Download
runtime/lib/double.cc View 3 chunks +3 lines, -9 lines 0 comments Download
runtime/lib/integers.cc View 1 chunk +1 line, -3 lines 0 comments Download
runtime/lib/isolate.cc View 3 chunks +2 lines, -9 lines 0 comments Download
runtime/lib/mirrors.cc View 1 chunk +1 line, -3 lines 0 comments Download
runtime/lib/string.cc View 4 chunks +7 lines, -17 lines 0 comments Download
runtime/lib/typed_data.cc View 7 chunks +7 lines, -21 lines 0 comments Download
runtime/vm/exceptions.h View 1 chunk +1 line, -0 lines 0 comments Download
runtime/vm/exceptions.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 2 months ago (2013-10-01 17:26:26 UTC) #1
siva
lgtm
7 years, 2 months ago (2013-10-01 18:36:25 UTC) #2
srdjan
7 years, 2 months ago (2013-10-01 18:48:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698