Issue 255633002: Enables simple static call test on arm64.

Issue 255633002: Enables simple static call test on arm64. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Enables simple static call test on arm64. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35380

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+170 lines, -36 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1	5 chunks	+21 lines, -12 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View	1	5 chunks	+33 lines, -16 lines	0 comments	Download
M	runtime/vm/code_generator_test.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		2 chunks	+44 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View		2 chunks	+64 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/255633002/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/255633002/diff/1/runtime/vm/assembler_arm64.cc#newcode834 runtime/vm/assembler_arm64.cc:834: sub(PP, PP, Operand(kHeapObjectTag)); It is surprising to see ...

6 years, 8 months ago (2014-04-24 16:20:07 UTC) #2

zra

Thanks! https://codereview.chromium.org/255633002/diff/1/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/255633002/diff/1/runtime/vm/assembler_arm64.cc#newcode834 runtime/vm/assembler_arm64.cc:834: sub(PP, PP, Operand(kHeapObjectTag)); On 2014/04/24 16:20:07, regis wrote: ...

6 years, 8 months ago (2014-04-24 16:29:00 UTC) #3

zra

6 years, 8 months ago (2014-04-24 16:29:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35380 (presubmit successful).

Expand Messages | Collapse Messages