Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 25561002: Disallow double in case clauses and const map literal keys (Closed)

Created:
7 years, 2 months ago by hausner
Modified:
7 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Disallow double in case clauses and const map literal keys Implements the latest Spec decisions and clarifications. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28104

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -39 lines) Patch
M runtime/vm/parser.cc View 1 4 chunks +28 lines, -12 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 chunks +2 lines, -0 lines 0 comments Download
A tests/language/switch_bad_case_test.dart View 1 chunk +36 lines, -0 lines 0 comments Download
D tests/language/switch_int_double_test.dart View 1 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 2 months ago (2013-10-01 16:55:04 UTC) #1
srdjan
lgtm
7 years, 2 months ago (2013-10-01 17:18:16 UTC) #2
hausner
Thank you.
7 years, 2 months ago (2013-10-01 17:21:30 UTC) #3
hausner
7 years, 2 months ago (2013-10-01 17:23:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r28104 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698