Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25559004: Handle exports being registered before declarations. (Closed)

Created:
7 years, 2 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Handle exports being registered before declarations. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=28221

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated status + comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M sdk/lib/_internal/compiler/implementation/library_loader.dart View 1 3 chunks +13 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/patch_parser.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Johnni Winther
7 years, 2 months ago (2013-10-03 13:30:40 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/25559004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/25559004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode757 sdk/lib/_internal/compiler/implementation/library_loader.dart:757: // Do nothing. [element] hides [existingElement]. Remove "Do ...
7 years, 2 months ago (2013-10-03 13:35:19 UTC) #2
Johnni Winther
https://codereview.chromium.org/25559004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart File sdk/lib/_internal/compiler/implementation/library_loader.dart (right): https://codereview.chromium.org/25559004/diff/1/sdk/lib/_internal/compiler/implementation/library_loader.dart#newcode757 sdk/lib/_internal/compiler/implementation/library_loader.dart:757: // Do nothing. [element] hides [existingElement]. On 2013/10/03 13:35:19, ...
7 years, 2 months ago (2013-10-03 13:38:51 UTC) #3
Johnni Winther
7 years, 2 months ago (2013-10-03 13:40:28 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r28221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698