Make JSON encoder take extra function argument to use instead of toJson calls.

Make JSON encoder take extra function argument to use instead of toJson calls.

Defaults to callin toJson() on unconvertible objects.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28507

[floitsch, 2013-10-04 15:25:08]

LGTM except for the name.
I would really like if we could come up with a better name.

https://codereview.chromium.org/25548010/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/25548010/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:104: Object encode(Object value, { convert(var object)
}) {
I'm not sold on the "convert" name.
Haven't yet come up with a better name, though.

https://codereview.chromium.org/25548010/diff/1/sdk/lib/json/json.dart
File sdk/lib/json/json.dart (right):

https://codereview.chromium.org/25548010/diff/1/sdk/lib/json/json.dart#newcode69
sdk/lib/json/json.dart:69: String stringify(Object object, [convert(object)]) {
You don't have the latest version (which now has deprecation notices).

But you should copy your changes into the json-package.

[kevmoo-old, 2013-10-04 16:31:08]

DBR

https://codereview.chromium.org/25548010/diff/1/pkg/json/lib/json.dart
File pkg/json/lib/json.dart (right):

https://codereview.chromium.org/25548010/diff/1/pkg/json/lib/json.dart#newcod...
pkg/json/lib/json.dart:670: StringSink sink;
final * 2

[Lasse Reichstein Nielsen, 2013-10-07 12:46:59]

https://codereview.chromium.org/25548010/diff/1/pkg/json/lib/json.dart
File pkg/json/lib/json.dart (right):

https://codereview.chromium.org/25548010/diff/1/pkg/json/lib/json.dart#newcod...
pkg/json/lib/json.dart:670: StringSink sink;
On 2013/10/04 16:31:08, kevmoo wrote:
> final * 2

Done.

https://codereview.chromium.org/25548010/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/25548010/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:104: Object encode(Object value, { convert(var object)
}) {
Me neither.
How about 'toJson'? Might be too confusing.

https://codereview.chromium.org/25548010/diff/1/sdk/lib/json/json.dart
File sdk/lib/json/json.dart (right):

https://codereview.chromium.org/25548010/diff/1/sdk/lib/json/json.dart#newcode69
sdk/lib/json/json.dart:69: String stringify(Object object, [convert(object)]) {
Merging .... please hold. :)

I don't want to support the json package with new functionality.
We moved it to a package in case someone was using it, but that was mainly for
the custom parser, not the stringifier. Eventually we could make the stringifier
in pkg/json use the convert library instead.

I changed the lib/json version because that's the one we use in convert, and the
one we'll eventually move into the convert library when we drop the json
library.

New users of the json library at this time will know it's deprecated, and can
use the convert library instead.

[Sean Eagan, 2013-10-07 15:24:31]

https://codereview.chromium.org/25548010/diff/1/sdk/lib/convert/json.dart
File sdk/lib/convert/json.dart (right):

https://codereview.chromium.org/25548010/diff/1/sdk/lib/convert/json.dart#new...
sdk/lib/convert/json.dart:104: Object encode(Object value, { convert(var object)
}) {
On 2013/10/07 12:46:59, Lasse Reichstein Nielsen wrote:
> Me neither.
> How about 'toJson'? Might be too confusing.

How about `onObjectWithoutBuiltinJsonSupport` except shorter, such as:

onExtrinsic
onAlien
onNonNative
onForeign
onUnfamiliar

?

[Lasse Reichstein Nielsen, 2013-10-11 11:34:56]

Committed patchset #4 manually as r28507 (presubmit successful).