Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 25539006: Reapply utf85_test. (Closed)

Created:
7 years, 2 months ago by floitsch
Modified:
7 years, 2 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply utf85_test. Bug in VM has been fixed. It shouldn't take that long anymore. This test was originally LGTMed in https://chromiumcodereview.appspot.com/25463003/ R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=28198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
A + tests/lib/convert/utf85_test.dart View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
7 years, 2 months ago (2013-10-02 17:33:35 UTC) #1
Florian Schneider
rubberstamp lgtm.
7 years, 2 months ago (2013-10-02 17:36:58 UTC) #2
floitsch
7 years, 2 months ago (2013-10-03 08:51:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28198 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698