Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25509007: Support unboxed SIMD types in AllocationSinking (Closed)

Created:
7 years, 2 months ago by Cutch
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Support unboxed SIMD types in AllocationSinking BUG= R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31752

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/vm/allocation_sinking_vm_test.dart View 1 2 4 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Cutch
7 years, 2 months ago (2013-10-02 22:15:24 UTC) #1
srdjan
LGTM after adding tests that verify this optimization.
7 years, 2 months ago (2013-10-03 16:15:20 UTC) #2
Cutch
On 2013/10/03 16:15:20, srdjan wrote: > LGTM after adding tests that verify this optimization. CL ...
6 years, 11 months ago (2014-01-13 17:57:12 UTC) #3
Cutch
BTW- I noticed that the optimized code has 4 boxing operations at the start (both ...
6 years, 11 months ago (2014-01-13 17:59:32 UTC) #4
srdjan
LGTM and please file a bug so that we can investigate/fix the extra boxing ops.
6 years, 11 months ago (2014-01-13 18:14:05 UTC) #5
Cutch
On 2014/01/13 18:14:05, srdjan wrote: > LGTM and please file a bug so that we ...
6 years, 11 months ago (2014-01-13 18:30:10 UTC) #6
Cutch
6 years, 11 months ago (2014-01-13 18:41:14 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 manually as r31752 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698