Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 25505008: Support compile time constant conditional expressions (Closed)

Created:
7 years, 2 months ago by hausner
Modified:
7 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Support compile time constant conditional expressions Per latest spec (section 12.1, 0.61 draft) R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M runtime/vm/ast.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/ast.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/compile_time_constant11_test.dart View 1 chunk +25 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 2 months ago (2013-10-01 22:15:25 UTC) #1
regis
LGTM
7 years, 2 months ago (2013-10-01 22:54:30 UTC) #2
hausner
Committed patchset #1 manually as r28131 (presubmit successful).
7 years, 2 months ago (2013-10-01 23:00:12 UTC) #3
hausner
7 years, 2 months ago (2013-10-01 23:04:07 UTC) #4
Message was sent while issue was closed.
Thank you.

Powered by Google App Engine
This is Rietveld 408576698