Issue 25505006: Report BUILT_IN_IDENTIFIER_AS_TYPE for formal parameters.

Issue 25505006: Report BUILT_IN_IDENTIFIER_AS_TYPE for formal parameters. (Closed)

Created:
7 years, 2 months ago by scheglov

Modified:
7 years, 2 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report BUILT_IN_IDENTIFIER_AS_TYPE for formal parameters. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28185

Patch Set 2 : Report BUILT_IN_IDENTIFIER_AS_TYPE in type resolver. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -46 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/TypeResolverVisitor.java	View	1	3 chunks	+30 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	2 chunks	+0 lines, -29 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View	1	1 chunk	+22 lines, -5 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM modulo comments https://codereview.chromium.org/25505006/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/25505006/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode186 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:186: StaticWarningCode.UNDEFINED_CLASS); Should we really be producing ...

7 years, 2 months ago (2013-10-01 23:06:14 UTC) #3

scheglov

PTAL https://codereview.chromium.org/25505006/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java (right): https://codereview.chromium.org/25505006/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java#newcode186 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java:186: StaticWarningCode.UNDEFINED_CLASS); On 2013/10/01 23:06:14, Brian Wilkerson wrote: > ...

7 years, 2 months ago (2013-10-02 20:45:02 UTC) #4

scheglov

7 years, 2 months ago (2013-10-02 22:02:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r28185 (presubmit successful).

Expand Messages | Collapse Messages