Issue 25504002: Emit a compile-time error for uninitialized final variables.

Issue 25504002: Emit a compile-time error for uninitialized final variables. (Closed)

Created:
7 years, 2 months ago by karlklose

Modified:
7 years, 2 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit a compile-time error for uninitialized final variables. BUG=13020, 13222 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=28204

Patch Set 4 : Implement check for all final variables. #

Patch Set 5 : dart2dart status file. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -12 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2 3	4 chunks	+17 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2 3	2 chunks	+7 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2 3 4	2 chunks	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://codereview.chromium.org/25504002/diff/4001/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/25504002/diff/4001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode460 sdk/lib/_internal/compiler/implementation/resolution/members.dart:460: compiler.reportError(element, Shouldn't this be a warning?

7 years, 2 months ago (2013-10-02 12:17:01 UTC) #2

kasperl

On 2013/10/02 12:17:01, kasperl wrote: > https://codereview.chromium.org/25504002/diff/4001/sdk/lib/_internal/compiler/implementation/resolution/members.dart > File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): > > https://codereview.chromium.org/25504002/diff/4001/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode460 > ...

7 years, 2 months ago (2013-10-02 12:22:19 UTC) #3

karlklose

7 years, 2 months ago (2013-10-03 10:42:40 UTC) #6

Message was sent while issue was closed.

Committed patchset #5 manually as r28204 (presubmit successful).

Expand Messages | Collapse Messages