Issue 25491002: x64: Use a short encoding of addq and subq for 32-bit immediates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25491002: x64: Use a short encoding of addq and subq for 32-bit immediates. (Closed)

Created:
7 years, 2 months ago by Kevin Millikin (Google)

Modified:
7 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

x64: Use a short encoding of addq and subq for 32-bit immediates. BUG=https://code.google.com/p/dart/issues/detail?id=13681 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=28087

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -9 lines)			Patch
	M	runtime/vm/assembler_x64.cc	View		2 chunks	+16 lines, -6 lines	0 comments	Download
	M	runtime/vm/code_patcher_x64.cc	View		1 chunk	+2 lines, -3 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://codereview.chromium.org/25491002/diff/1/runtime/vm/code_patcher_x64.cc File runtime/vm/code_patcher_x64.cc (right): https://codereview.chromium.org/25491002/diff/1/runtime/vm/code_patcher_x64.cc#newcode273 runtime/vm/code_patcher_x64.cc:273: // 48 83 40 17 02 addq [rax+0x17],0x2 ...

7 years, 2 months ago (2013-10-01 11:11:05 UTC) #2

Florian Schneider

On 2013/10/01 11:11:05, Florian Schneider wrote: > lgtm > > https://codereview.chromium.org/25491002/diff/1/runtime/vm/code_patcher_x64.cc > File runtime/vm/code_patcher_x64.cc (right): ...

7 years, 2 months ago (2013-10-01 11:12:11 UTC) #3

Kevin Millikin (Google)

7 years, 2 months ago (2013-10-01 11:18:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r28087 (presubmit successful).

Expand Messages | Collapse Messages