Issue 25479004: Mark "failure" for analyzer on mirrors/redirection_type_shuffling. Multitest cannot express a situt…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25479004: Mark "failure" for analyzer on mirrors/redirection_type_shuffling. Multitest cannot express a situt… (Closed)

Created:
7 years, 2 months ago by rmacnak

Modified:
7 years, 2 months ago

Reviewers:
regis, Brian Wilkerson

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Mark "failure" for analyzer on mirrors/redirection_type_shuffling. Multitest cannot express a situtation where something should fail in checked mode on the VM or dart2js but not in the analyzer. TBR Committed: https://code.google.com/p/dart/source/detail?r=28113

Patch Set 1 : . #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Committed patchset #1 manually as r28113 (presubmit successful).

7 years, 2 months ago (2013-10-01 19:46:47 UTC) #2

Brian Wilkerson

I'm not as familiar with the test framework as I'd like to be, but I ...

7 years, 2 months ago (2013-10-01 19:48:31 UTC) #3

regis

7 years, 2 months ago (2013-10-01 20:04:44 UTC) #4

Message was sent while issue was closed.

LGTM to make the build bot green.

However, it would be better to catch the error in this test and let it pass
cleanly through the analyzer.

Expand Messages | Collapse Messages