Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25471003: Modify tests to use Directory.systemTemp (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Modify tests to use Directory.systemTemp. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28219

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use Directory.systemTemp getter. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -237 lines) Patch
M tests/standalone/io/dart_std_io_pipe_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/delete_symlink_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_chdir_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_create_race_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_error_test.dart View 1 4 chunks +5 lines, -6 lines 0 comments Download
M tests/standalone/io/directory_fuzz_test.dart View 1 3 chunks +8 lines, -2 lines 0 comments Download
M tests/standalone/io/directory_list_nonexistent_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/directory_list_pause_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_non_ascii_sync_test.dart View 1 2 chunks +7 lines, -2 lines 0 comments Download
M tests/standalone/io/directory_non_ascii_test.dart View 1 1 chunk +21 lines, -19 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 1 26 chunks +53 lines, -42 lines 0 comments Download
M tests/standalone/io/file_error_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_fuzz_test.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M tests/standalone/io/file_input_stream_test.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/file_non_ascii_sync_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/file_non_ascii_test.dart View 1 1 chunk +24 lines, -24 lines 0 comments Download
M tests/standalone/io/file_output_stream_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/file_read_encoded_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_stat_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/file_system_async_links_test.dart View 1 5 chunks +52 lines, -42 lines 0 comments Download
M tests/standalone/io/file_system_delete_test.dart View 1 10 chunks +10 lines, -10 lines 0 comments Download
M tests/standalone/io/file_system_exists_test.dart View 1 10 chunks +10 lines, -10 lines 0 comments Download
M tests/standalone/io/file_system_links_test.dart View 1 7 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/io/file_system_watcher_test.dart View 1 8 chunks +8 lines, -8 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_typed_data_test.dart View 1 9 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/io/file_write_as_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_client_connect_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/http_cookie_date_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/http_headers_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/link_async_test.dart View 1 4 chunks +11 lines, -4 lines 0 comments Download
M tests/standalone/io/link_test.dart View 1 4 chunks +12 lines, -5 lines 0 comments Download
M tests/standalone/io/pipe_server_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_non_ascii_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/process_working_directory_test.dart View 1 2 chunks +4 lines, -2 lines 0 comments Download
M tests/standalone/io/regress_7679_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/resolve_symbolic_links_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/skipping_dart2js_compilations_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/stdout_close_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/stream_pipe_test.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/test_extension_fail_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/test_extension_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/standalone/io/windows_environment_test.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download
M tests/standalone/io/windows_file_system_async_links_test.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M tests/standalone/io/windows_file_system_links_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 2 months ago (2013-10-01 13:35:01 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/25471003/diff/1/tests/standalone/io/dart_std_io_pipe_test.dart File tests/standalone/io/dart_std_io_pipe_test.dart (right): https://codereview.chromium.org/25471003/diff/1/tests/standalone/io/dart_std_io_pipe_test.dart#newcode35 tests/standalone/io/dart_std_io_pipe_test.dart:35: Directory dir = Directory.createSystemTempSync('dart_dart_std_io_pipe'); Great to have the ...
7 years, 2 months ago (2013-10-01 14:38:41 UTC) #2
Bill Hesse
7 years, 2 months ago (2013-10-03 13:28:59 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r28219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698