Issue 25465002: Always mark stdout as blocking when using 'print'.

Issue 25465002: Always mark stdout as blocking when using 'print'. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years, 2 months ago

Reviewers:
Søren Gjesse, karlklose

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Always mark stdout as blocking when using 'print'. BUG=http://code.google.com/p/dart/issues/detail?id=13712 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28081

Patch Set 1 #

Total comments: 4

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -19 lines)			Patch
M	runtime/bin/builtin_natives.cc	View	2 chunks	+3 lines, -4 lines	2 comments	Download
M	runtime/bin/platform.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_android.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_linux.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_macos.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_win.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	tests/standalone/io/print_sync_script.dart	View	1 chunk	+22 lines, -0 lines	2 comments	Download
A +	tests/standalone/io/print_sync_test.dart	View	1 chunk	+11 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM https://codereview.chromium.org/25465002/diff/1/runtime/bin/builtin_natives.cc File runtime/bin/builtin_natives.cc (right): https://codereview.chromium.org/25465002/diff/1/runtime/bin/builtin_natives.cc#newcode114 runtime/bin/builtin_natives.cc:114: Platform::PrintBlocking(stdout, "%.*s\n", length, chars); I was not aware ...

7 years, 2 months ago (2013-10-01 07:16:39 UTC) #2

Anders Johnsen

https://codereview.chromium.org/25465002/diff/1/runtime/bin/builtin_natives.cc File runtime/bin/builtin_natives.cc (right): https://codereview.chromium.org/25465002/diff/1/runtime/bin/builtin_natives.cc#newcode114 runtime/bin/builtin_natives.cc:114: Platform::PrintBlocking(stdout, "%.*s\n", length, chars); On 2013/10/01 07:16:39, Søren Gjesse ...

7 years, 2 months ago (2013-10-01 09:05:20 UTC) #3

Anders Johnsen

Committed patchset #1 manually as r28081 (presubmit successful).

7 years, 2 months ago (2013-10-01 09:06:08 UTC) #4

karlklose

https://codereview.chromium.org/25465002/diff/1/tests/standalone/io/print_sync_script.dart File tests/standalone/io/print_sync_script.dart (right): https://codereview.chromium.org/25465002/diff/1/tests/standalone/io/print_sync_script.dart#newcode20 tests/standalone/io/print_sync_script.dart:20: stdout; // Be sure too mark stdout as non-blocking. ...

7 years, 2 months ago (2013-10-01 09:13:45 UTC) #5

Anders Johnsen

7 years, 2 months ago (2013-10-01 09:16:56 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/25401004

https://codereview.chromium.org/25465002/diff/1/tests/standalone/io/print_syn...
File tests/standalone/io/print_sync_script.dart (right):

https://codereview.chromium.org/25465002/diff/1/tests/standalone/io/print_syn...
tests/standalone/io/print_sync_script.dart:20: stdout;  // Be sure too mark
stdout as non-blocking.
On 2013/10/01 09:13:45, karlklose wrote:
> 'too' -> 'to'.

Done.

Expand Messages | Collapse Messages