Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 25456005: Add type check to const conditional expression evaluation (Closed)

Created:
7 years, 2 months ago by hausner
Modified:
7 years, 2 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org, kasperl, Johnni Winther
Visibility:
Public.

Description

Add type check to const conditional expression evaluation issue 13746 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28182

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M runtime/vm/ast.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hausner
7 years, 2 months ago (2013-10-02 17:48:25 UTC) #1
srdjan
Isn't the compilation error confusing now "expression must be a compile-time constant")? It should be ...
7 years, 2 months ago (2013-10-02 17:55:12 UTC) #2
hausner
We don't have the ability to report why an expression is not a compile-time constant ...
7 years, 2 months ago (2013-10-02 18:14:01 UTC) #3
hausner
Changed the error message to "is not a valid compile-time constant".
7 years, 2 months ago (2013-10-02 18:19:49 UTC) #4
srdjan
lgtm
7 years, 2 months ago (2013-10-02 18:51:07 UTC) #5
hausner
7 years, 2 months ago (2013-10-02 21:08:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r28182 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698