Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 254533004: Use @MirrorsUsed to prevent analysis server tests from slowing down in dart2js. (Closed)

Created:
6 years, 8 months ago by Paul Berry
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use @MirrorsUsed to prevent analysis server tests from slowing down in dart2js. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=35396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pkg/analysis_server/test/mocks.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Berry
6 years, 8 months ago (2014-04-24 20:01:01 UTC) #1
scheglov
lgtm
6 years, 8 months ago (2014-04-24 20:02:28 UTC) #2
Paul Berry
Committed patchset #1 manually as r35396 (presubmit successful).
6 years, 8 months ago (2014-04-24 20:11:30 UTC) #3
Brian Wilkerson
6 years, 8 months ago (2014-04-25 14:55:48 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698