Issue 254483005: - Rationalize the way we use comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254483005: - Rationalize the way we use comments. (Closed)

Created:
6 years, 8 months ago by Ivan Posva

Modified:
6 years, 8 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -14 lines)			Patch
M	runtime/vm/assembler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

6 years, 8 months ago (2014-04-24 01:57:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35349 (presubmit successful).