Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 25446003: Improve --optimization-filter to accept a comma-separated list of strings. (Closed)

Created:
7 years, 2 months ago by Florian Schneider
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Improve --optimization-filter to accept a comma-separated list of strings. Only functions where the fully-qualified name contains one of the strings supplied as substring will be optimized. This helps tracking down bugs in the optimizing compiler that occur when a large number of optimized functions are involved. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=28578

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M runtime/vm/code_generator.cc View 1 chunk +22 lines, -5 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 2 months ago (2013-10-02 10:26:34 UTC) #1
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/25446003/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/25446003/diff/1/runtime/vm/code_generator.cc#newcode1252 runtime/vm/code_generator.cc:1252: while (token != NULL) { Without the found ...
7 years, 2 months ago (2013-10-14 11:09:28 UTC) #2
Florian Schneider
7 years, 2 months ago (2013-10-14 12:21:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28578 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698