Issue 25439002: fix observe transform to preserve metadata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25439002: fix observe transform to preserve metadata (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly

Modified:
7 years, 2 months ago

Reviewers:
justinfagnani, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fix observe transform to preserve metadata R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=28133

Patch Set 4 : use isPrivateName #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -72 lines)			Patch
M	pkg/observe/lib/transform.dart	View	1 2 3	5 chunks	+82 lines, -29 lines	0 comments	Download
M	pkg/observe/test/transform_test.dart	View	1 2	2 chunks	+63 lines, -29 lines	0 comments	Download
M	pkg/polymer/test/build/all_phases_test.dart	View		1 chunk	+11 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Hey Justin, do you mind taking a look at this? I'd like to land my ...

7 years, 2 months ago (2013-10-01 03:40:16 UTC) #1

scheglov

lgtm https://codereview.chromium.org/25439002/diff/6001/pkg/observe/lib/transform.dart File pkg/observe/lib/transform.dart (right): https://codereview.chromium.org/25439002/diff/6001/pkg/observe/lib/transform.dart#newcode305 pkg/observe/lib/transform.dart:305: if (name.startsWith('_')) { You could also use SimpleIdentifier.isPrivateName().

7 years, 2 months ago (2013-10-01 23:21:13 UTC) #2

Jennifer Messerly

7 years, 2 months ago (2013-10-01 23:37:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r28133 (presubmit successful).

Expand Messages | Collapse Messages

Issue 25439002: fix observe transform to preserve metadata (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : use isPrivateName #

Messages