Issue 254383003: Small fixes for Android.

Issue 254383003: Small fixes for Android. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 8 months ago

Reviewers:
Cutch, Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Anders Johnsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Small fixes for Android. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35342

Patch Set 3 : #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -12 lines)			Patch
M	runtime/bin/socket_android.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
M	runtime/platform/thread_android.cc	View	1 2	3 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/profiler.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/signal_handler.h	View		1 chunk	+10 lines, -1 line	0 comments	Download
M	runtime/vm/signal_handler_android.cc	View		1 chunk	+32 lines, -2 lines	0 comments	Download
M	runtime/vm/thread_interrupter_android.cc	View		3 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Cutch

https://codereview.chromium.org/254383003/diff/20001/runtime/platform/thread_android.cc File runtime/platform/thread_android.cc (right): https://codereview.chromium.org/254383003/diff/20001/runtime/platform/thread_android.cc#newcode159 runtime/platform/thread_android.cc:159: return pthread_equal(a, b) != 0; This needs to be ...

6 years, 8 months ago (2014-04-23 23:07:14 UTC) #2

zra

6 years, 8 months ago (2014-04-23 23:12:07 UTC) #3

zra

Committed patchset #3 manually as r35342 (presubmit successful).

6 years, 8 months ago (2014-04-23 23:20:28 UTC) #5

Anders Johnsen

6 years, 8 months ago (2014-04-24 06:49:00 UTC) #6

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/254383003/diff/40001/runtime/bin/socket_andro...
File runtime/bin/socket_android.cc (right):

https://codereview.chromium.org/254383003/diff/40001/runtime/bin/socket_andro...
runtime/bin/socket_android.cc:224: hints.ai_flags = 0;
Please clean up the code below, as well. Why can we not use AI_ADDRCONFIG? It's
quite important if IPv6 is enabled.

Expand Messages | Collapse Messages