Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 25428003: Fix warnings and hints. (Closed)

Created:
7 years, 2 months ago by kasperl
Modified:
7 years, 2 months ago
Reviewers:
bakster, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Break long line. #

Patch Set 3 : Less hiding FTW. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M pkg/polymer/lib/platform.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/utf/lib/utf.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/utf/lib/utf16.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/utf/lib/utf32.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/utf/lib/utf8.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/utf/lib/utf_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart View 1 2 1 chunk +6 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/token.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 2 months ago (2013-10-03 12:26:59 UTC) #1
ahe
LGTM!
7 years, 2 months ago (2013-10-03 12:47:02 UTC) #2
kasperl
7 years, 2 months ago (2013-10-03 13:12:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r28217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698