Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 25426007: dart:io | Replace duplicate implementation with Uri.resolveUri in HttpClient. (Closed)

Created:
7 years, 2 months ago by Bill Hesse
Modified:
7 years, 2 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Replace duplicate implementation with Uri.resolveUri in HttpClient. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=28261

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M sdk/lib/io/http_impl.dart View 1 chunk +2 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 2 months ago (2013-10-04 09:19:19 UTC) #1
Søren Gjesse
LGTM! Good catch!
7 years, 2 months ago (2013-10-04 09:37:49 UTC) #2
Bill Hesse
7 years, 2 months ago (2013-10-04 11:21:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28261 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698