Issue 25418002: Respond to Ivan's code review comments from previous TBR cl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25418002: Respond to Ivan's code review comments from previous TBR cl. (Closed)

Created:
7 years, 2 months ago by Jacob

Modified:
7 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Respond to Ivan's code review comments from previous TBR cl. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28135

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	runtime/vm/object.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	runtime/vm/object_test.cc	View	1	1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

Ivan Posva

This seems to have addressed the build issue. We'll deal with the bad cast. -Ivan ...

7 years, 2 months ago (2013-10-01 03:14:22 UTC) #2

Jacob

Address all code review comments. Also cleaned up the test code switching to Symbols::Empty() where ...

7 years, 2 months ago (2013-10-01 17:25:26 UTC) #3

Jacob

7 years, 2 months ago (2013-10-01 23:48:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r28135 (presubmit successful).