Issue 25415002: TBR: fix build break

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25415002: TBR: fix build break (Closed)

Created:
7 years, 2 months ago by Jacob

Modified:
7 years, 2 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

TBR: fix build break BUG= Committed: https://code.google.com/p/dart/source/detail?r=28076

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	runtime/vm/object_test.cc	View	1	2 chunks	+4 lines, -2 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jacob

Committed patchset #3 manually as r28076 (presubmit successful).

7 years, 2 months ago (2013-10-01 00:45:17 UTC) #1

Ivan Posva

7 years, 2 months ago (2013-10-01 03:21:22 UTC) #2

Message was sent while issue was closed.

LGTM -ip

https://codereview.chromium.org/25415002/diff/6001/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/25415002/diff/6001/runtime/vm/object_test.cc#...
runtime/vm/object_test.cc:1548: OneByteString::New(static_cast<intptr_t>(0),
Heap::kNew));
You can remove the this whole line and replace the parameter of
EscapeSpecialCharacters with Symbols::Empty().

https://codereview.chromium.org/25415002/diff/6001/runtime/vm/object_test.cc#...
runtime/vm/object_test.cc:1551: EXPECT_EQ(empty_str.Length(), 0);
This is a redundant check. If Symbols::Empty() is not empty we have bigger
issues.

Expand Messages | Collapse Messages